Skip to content

Conversation

@worldbeater
Copy link
Contributor

What kind of change does this PR introduce?

Fix ReactiveUI.Uno project compilation.

What is the current behavior?

Something changed in Uno API so our CI checks fail now with CS0201 and CS0029

What is the new behavior?

The solution builds locally so let's see if it does on the CI server.

What might this PR break?

Nothing.

worldbeater and others added 2 commits August 6, 2019 14:56
Bumps [Microsoft.Reactive.Testing](https://github.com/dotnet/reactive) from 4.1.5 to 4.1.6.
- [Release notes](https://github.com/dotnet/reactive/releases)
- [Commits](dotnet/reactive@rxnet-v4.1.5...rxnet-v4.1.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@worldbeater worldbeater added housekeeping dependencies Pull requests that update a dependency file labels Aug 6, 2019
@worldbeater worldbeater marked this pull request as ready for review August 6, 2019 12:41
@worldbeater worldbeater requested review from a team August 6, 2019 12:41
@codecov
Copy link

codecov bot commented Aug 6, 2019

Codecov Report

Merging #2130 into master will increase coverage by 0.76%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2130      +/-   ##
==========================================
+ Coverage   58.06%   58.82%   +0.76%     
==========================================
  Files         117      117              
  Lines        4614     4760     +146     
  Branches      718      740      +22     
==========================================
+ Hits         2679     2800     +121     
- Misses       1712     1727      +15     
- Partials      223      233      +10
Impacted Files Coverage Δ
src/ReactiveUI/Comparers/OrderedComparer.cs 63.63% <0%> (-19.7%) ⬇️
...tiveUI/ReactiveObject/IReactiveObjectExtensions.cs 95.49% <0%> (-4.51%) ⬇️
src/ReactiveUI/Legacy/ReactiveDerivedCollection.cs 40.26% <0%> (-0.41%) ⬇️
...eactiveUI/ReactiveCommand/ReactiveCommandMixins.cs 96.22% <0%> (+0.77%) ⬆️
src/ReactiveUI/ReactiveCommand/ReactiveCommand.cs 80.21% <0%> (+0.88%) ⬆️
src/ReactiveUI/EventManagers/WeakEventManager.cs 63.76% <0%> (+3.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c4a36c...0d7d1c1. Read the comment docs.

@glennawatson glennawatson merged commit e2a31cf into master Aug 6, 2019
@glennawatson glennawatson deleted the uno-fix branch August 6, 2019 13:09
@glennawatson glennawatson restored the uno-fix branch August 15, 2019 05:18
@glennawatson glennawatson deleted the uno-fix branch August 15, 2019 05:51
@lock lock bot locked and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file housekeeping

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants