-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feature: Add Roslyn Analyzer for Fody plugin #2199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider registering other actions that act on syntax instead of or in addition to symbolsReactiveUI/src/ReactiveUI.Fody.Analyzer/ReactiveObjectAnalyzer.cs Lines 55 to 60 in 61b7e15
This comment was generated by todo based on a
|
RLittlesII
requested changes
Oct 9, 2019
Member
RLittlesII
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the build script won't build or test this project. It should be added to the white list.
Lines 16 to 30 in 1357b14
| var packageWhitelist = new List<FilePath> | |
| { | |
| MakeAbsolute(File("./src/ReactiveUI/ReactiveUI.csproj")), | |
| MakeAbsolute(File("./src/ReactiveUI.Testing/ReactiveUI.Testing.csproj")), | |
| MakeAbsolute(File("./src/ReactiveUI.Events/ReactiveUI.Events.csproj")), | |
| MakeAbsolute(File("./src/ReactiveUI.Events.XamEssentials/ReactiveUI.Events.XamEssentials.csproj")), | |
| MakeAbsolute(File("./src/ReactiveUI.Events.XamForms/ReactiveUI.Events.XamForms.csproj")), | |
| MakeAbsolute(File("./src/ReactiveUI.Fody/ReactiveUI.Fody.csproj")), | |
| MakeAbsolute(File("./src/ReactiveUI.Fody.Helpers/ReactiveUI.Fody.Helpers.csproj")), | |
| MakeAbsolute(File("./src/ReactiveUI.AndroidSupport/ReactiveUI.AndroidSupport.csproj")), | |
| MakeAbsolute(File("./src/ReactiveUI.AndroidX/ReactiveUI.AndroidX.csproj")), | |
| MakeAbsolute(File("./src/ReactiveUI.XamForms/ReactiveUI.XamForms.csproj")), | |
| MakeAbsolute(File("./src/ReactiveUI.Uno/ReactiveUI.Uno.csproj")), | |
| MakeAbsolute(File("./src/ReactiveUI.Blazor/ReactiveUI.Blazor.csproj")), | |
| }; |
glennawatson
requested changes
Oct 10, 2019
src/ReactiveUI.Fody.Analyzer.Test/ReactiveUI.Fody.Analyzer.Test.csproj
Outdated
Show resolved
Hide resolved
glennawatson
approved these changes
Oct 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature. This adds a new Roslyn code analyzer that ensures that the [Reactive] attribute is added only to classes that implement IReactiveObject.
Unfortunately, I do not have the expertise to wrap this up in a nuget package
What is the current behavior?
When a user tries to add the [Reactive] attribute to a property on a class that does not implement IReactiveObject, the weaving silently fails.
What is the new behavior?
When a user tries to add the [Reactive] attribute to a property on a class that does not implement IReactiveObject, the IDE should give a compile time error.
What might this PR break?
None
Please check if the PR fulfills these requirements