Update and fix to ReactiveComponentBase and ReactiveLayoutComponentBase #2318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennawatson
requested changes
Jan 17, 2020
glennawatson
approved these changes
Jan 17, 2020
| { | ||
| this.WhenAnyValue(x => x.ViewModel).Subscribe(_ => StateHasChanged()); | ||
| var viewModelsPropertyChanged = this.WhenAnyValue(x => x.ViewModel) | ||
| var viewModelsChangedObservable = this.WhenAnyValue(x => x.ViewModel) |
Contributor
There was a problem hiding this comment.
To keep the pr precise let's go back to the old ordering and variable names. Eg the view model change first and viewModelsPropertyChanged
glennawatson
requested changes
Jan 17, 2020
Contributor
glennawatson
left a comment
glennawatson
left a comment
There was a problem hiding this comment.
Setting to request changes
glennawatson
approved these changes
Jan 17, 2020
Contributor
|
btw, this went to the wrong branch :( |
Contributor
Author
|
Hah! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix to resolve #2308
What is the current behavior?
Views inheriting from
ReactiveComponentBase<T>and/orReactiveLayoutComponentBase<T>crash on initializationWhat is the new behavior?
Views inheriting from
ReactiveComponentBase<T>and/orReactiveLayoutComponentBase<T>do not crash on initializationWhat might this PR break?
Nothing that ain't already broken
Please check if the PR fulfills these requirements