Skip to content

Conversation

@glennawatson
Copy link
Contributor

No description provided.

* Update ReactiveComponentBase.cs

* Added @limefrogyank's fix, reverted variable name

* Changes to enable testing

* reverted proj file now tested

* Changed back to indented in both files

* Reverted ordering and variable name
@glennawatson glennawatson requested a review from a team January 18, 2020 00:16
@codecov
Copy link

codecov bot commented Jan 18, 2020

Codecov Report

Merging #2319 into master will decrease coverage by 0.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2319     +/-   ##
=========================================
- Coverage   55.32%   54.73%   -0.6%     
=========================================
  Files         113      113             
  Lines        4334     4334             
  Branches      660      660             
=========================================
- Hits         2398     2372     -26     
- Misses       1771     1797     +26     
  Partials      165      165
Impacted Files Coverage Δ
...I.Winforms/WinformsCreatesObservableForProperty.cs 26.31% <0%> (-68.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f237bf5...9701006. Read the comment docs.

@glennawatson glennawatson merged commit b3fc91c into master Jan 18, 2020
@glennawatson glennawatson deleted the Investigate_ReactiveComponentBase branch January 18, 2020 00:34
@lock lock bot locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants