Skip to content

Conversation

@ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

update WhenAny WhenAnyValue to use nullable for selector
fix #2812 ToProperty to work with nullable OAPH and non nullable OAPH

What is the current behaviour?

causes compiler issue or runtime exception

What is the new behaviour?

WhenAnyValue and ToProperty can be used in conjunction with each other without compiler warnings or runtime exceptions.

What might this PR break?

nullablilty of OAPH needs to be checked.

Please check if the PR fulfils these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #2860 (f77da5f) into main (259f4aa) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2860      +/-   ##
==========================================
+ Coverage   71.81%   71.82%   +0.01%     
==========================================
  Files         137      137              
  Lines        4828     4824       -4     
==========================================
- Hits         3467     3465       -2     
+ Misses       1361     1359       -2     
Impacted Files Coverage Δ
...eUI.Fody.Helpers/ObservableAsPropertyExtensions.cs 41.93% <ø> (ø)
...I/ObservableForProperty/OAPHCreationHelperMixin.cs 38.40% <ø> (ø)
src/ReactiveUI/VariadicTemplates.cs 53.36% <ø> (ø)
...iveUI/Mixins/ReactiveNotifyPropertyChangedMixin.cs 85.71% <100.00%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 259f4aa...f77da5f. Read the comment docs.

@ChrisPulman ChrisPulman marked this pull request as ready for review August 7, 2021 09:34
@ChrisPulman ChrisPulman mentioned this pull request Aug 7, 2021
2 tasks
@ChrisPulman ChrisPulman enabled auto-merge (squash) August 7, 2021 15:13
@ChrisPulman ChrisPulman merged commit 085b46b into main Aug 7, 2021
@ChrisPulman ChrisPulman deleted the update_UseNullableInSelector_SplatAlignment branch August 7, 2021 22:40
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Version 14.1.1 WhenAny.. now returns observable to a nullable regardless of parameter type

3 participants