-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix for WhenAny WhenAnyValue ToProperty #2860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Need to add tests
Codecov Report
@@ Coverage Diff @@
## main #2860 +/- ##
==========================================
+ Coverage 71.81% 71.82% +0.01%
==========================================
Files 137 137
Lines 4828 4824 -4
==========================================
- Hits 3467 3465 -2
+ Misses 1361 1359 -2
Continue to review full report at Codecov.
|
Add test
need to fix Splat.DryIoc to complete V12 update
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What kind of change does this PR introduce?
update WhenAny WhenAnyValue to use nullable for selector
fix #2812 ToProperty to work with nullable OAPH and non nullable OAPH
What is the current behaviour?
causes compiler issue or runtime exception
What is the new behaviour?
WhenAnyValue and ToProperty can be used in conjunction with each other without compiler warnings or runtime exceptions.
What might this PR break?
nullablilty of OAPH needs to be checked.
Please check if the PR fulfils these requirements
Other information: