Skip to content

Conversation

@ChrisPulman
Copy link
Member

Added test and updated command to ensure is executing is reset

What kind of change does this PR introduce?

fix

What is the current behaviour?

IsExecuting is not reset in a timely manner

What is the new behaviour?

IsExectuting is now reset along with the exception being raised allowing for a more aligned result

What might this PR break?

none expected

Please check if the PR fulfils these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

Added test and updated command to ensure is executing is reset
@ChrisPulman
Copy link
Member Author

pending #2860 to be committed to merge sources

@ChrisPulman ChrisPulman enabled auto-merge (squash) August 7, 2021 15:12
@codecov
Copy link

codecov bot commented Aug 7, 2021

Codecov Report

Merging #2863 (a2c67fc) into main (179055c) will increase coverage by 0.04%.
The diff coverage is 96.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2863      +/-   ##
==========================================
+ Coverage   71.82%   71.87%   +0.04%     
==========================================
  Files         137      137              
  Lines        4824     4828       +4     
==========================================
+ Hits         3465     3470       +5     
+ Misses       1359     1358       -1     
Impacted Files Coverage Δ
src/ReactiveUI/ReactiveCommand/ReactiveCommand.cs 82.87% <96.55%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 179055c...a2c67fc. Read the comment docs.

@ChrisPulman ChrisPulman merged commit 9b61437 into main Aug 7, 2021
@ChrisPulman ChrisPulman deleted the fix_2859_CommandExecuting branch August 7, 2021 23:28
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] ReactiveCommand's IsExecuting not set to False after command throwing exception

3 participants