Skip to content

Conversation

@ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

feature

What is the current behaviour?

few default converters exist

What is the new behaviour?

Add Byte, Short, Integer and Long to String BindingTypeConverters

What might this PR break?

users should set any custom BindingTypeConverters to an affinity > 10

Please check if the PR fulfils these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #2872 (6cc4aa3) into main (0df15d2) will increase coverage by 0.06%.
The diff coverage is 92.50%.

❗ Current head 6cc4aa3 differs from pull request most recent head 6489ee1. Consider uploading reports for the commit 6489ee1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2872      +/-   ##
==========================================
+ Coverage   72.24%   72.31%   +0.06%     
==========================================
  Files         140      144       +4     
  Lines        4926     5006      +80     
==========================================
+ Hits         3559     3620      +61     
- Misses       1367     1386      +19     
Impacted Files Coverage Δ
...UI/Bindings/Converter/ByteToStringTypeConverter.cs 88.88% <88.88%> (ø)
...UI/Bindings/Converter/LongToStringTypeConverter.cs 88.88% <88.88%> (ø)
...I/Bindings/Converter/ShortToStringTypeConverter.cs 88.88% <88.88%> (ø)
src/ReactiveUI.XamForms/Registrations.cs 91.66% <100.00%> (+4.16%) ⬆️
...Bindings/Converter/IntegerToStringTypeConverter.cs 100.00% <100.00%> (ø)
src/ReactiveUI/Registration/Registrations.cs 94.73% <100.00%> (+1.40%) ⬆️
...veUI/Platforms/net4/ComponentModelTypeConverter.cs 52.77% <0.00%> (-33.34%) ⬇️
...atforms/netcoreapp3/ComponentModelTypeConverter.cs 62.22% <0.00%> (-26.67%) ⬇️
...veUI/Platforms/net5/ComponentModelTypeConverter.cs 77.77% <0.00%> (-11.12%) ⬇️
...ctiveUI/Platforms/windows-common/RoutedViewHost.cs 86.44% <0.00%> (-1.70%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c814fd...6489ee1. Read the comment docs.

added check for override to make new in apple common to try and remove warnings
@ChrisPulman ChrisPulman marked this pull request as ready for review August 15, 2021 13:33
@ChrisPulman ChrisPulman enabled auto-merge (squash) August 15, 2021 23:07
@ChrisPulman ChrisPulman merged commit b6cad55 into main Aug 16, 2021
@ChrisPulman ChrisPulman deleted the feature_AddBindingTypeConverters branch August 16, 2021 01:48
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants