Refactor command parameter handling for WinForms binding #4278
+829
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies command parameter subscription and usage by removing redundant local variables and consistently using 'latestParameter'. Updates CompositeDisposable initialization and improves code clarity in command binding logic.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4278 +/- ##
==========================================
+ Coverage 89.43% 89.78% +0.35%
==========================================
Files 251 251
Lines 9561 9559 -2
Branches 1456 1456
==========================================
+ Hits 8551 8583 +32
+ Misses 771 741 -30
+ Partials 239 235 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Probably be worth bumping the testing up with CreatesWinformsCommandBinding.cs |
Introduces a full test suite for CreatesWinformsCommandBinding, covering affinity detection, command binding for various WinForms controls and components, event handler overloads, parameter passing, enabled state synchronization, and error handling. Also adds supporting mock classes for custom controls and components used in the tests. Removes unnecessary RequiresUnreferencedCode attributes from the implementation and updates XML documentation for clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Update
What is the new behavior?
Simplifies command parameter subscription and usage by removing redundant local variables and consistently using 'latestParameter'.
Updates CompositeDisposable initialization and improves code clarity in command binding logic.
What might this PR break?
None expected
Please check if the PR fulfills these requirements
Other information: