Call WithCoreServices and add platform converters#4316
Merged
ChrisPulman merged 2 commits intomainfrom Mar 31, 2026
Merged
Conversation
Ensure core services are initialized before configuring platform-specific builders by calling WithCoreServices() (cast back to IReactiveUIBuilder) in AndroidX, Blazor, MAUI and WinUI builder extensions. Add MAUI and WinUI converter registration helpers (WithMauiConverters and WithWinUIConverters) that register BooleanToVisibilityTypeConverter, VisibilityToBooleanTypeConverter and ComponentModelFallbackConverter via the builder's WithConverter/WithFallbackConverter APIs. Also add required using directives for MAUI and update WinUI scheduler XML docs; null checks use ArgumentExceptionHelper.ThrowIfNull.
glennawatson
approved these changes
Mar 30, 2026
Update the IAppBuilder test stub in BlazorReactiveUIBuilderExtensionsTests.cs so WithCoreServices returns the builder instance instead of throwing NotImplementedException. This prevents test failures when WithCoreServices is invoked and preserves fluent chaining on the stub.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4316 +/- ##
==========================================
- Coverage 89.70% 89.68% -0.02%
==========================================
Files 251 251
Lines 9612 9618 +6
Branches 1460 1460
==========================================
+ Hits 8622 8626 +4
- Misses 750 753 +3
+ Partials 240 239 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
update
What is the new behavior?
Ensure core services are initialized before configuring platform-specific builders by calling WithCoreServices() (cast back to IReactiveUIBuilder) in AndroidX, Blazor, MAUI and WinUI builder extensions. Add MAUI and WinUI converter registration helpers (WithMauiConverters and WithWinUIConverters) that register BooleanToVisibilityTypeConverter, VisibilityToBooleanTypeConverter and ComponentModelFallbackConverter via the builder's WithConverter/WithFallbackConverter APIs. Also add required using directives for MAUI and update WinUI scheduler XML docs; null checks use ArgumentExceptionHelper.ThrowIfNull.
What might this PR break?
If a user has called WithCoreServices() already in code they should clean up the existing source to remove this unless a custom configuration has been made.
Please check if the PR fulfills these requirements
Other information: