Fix 3921 Support inherited DependencyProperty lookup#4350
Merged
ChrisPulman merged 1 commit intomainfrom May 4, 2026
Merged
Conversation
Use DependencyPropertyDescriptor.FromName to resolve dependency properties declared on base control types (via DependencyObjectType.SystemType) and return the descriptor's DependencyProperty when found; fall back to existing enumeration otherwise. Add System.ComponentModel using and unit tests covering inherited property lookup (Selector.SelectedValue, TextBoxBase.IsReadOnly) and a BindWithValidation test for ComboBox.SelectedValue, plus a small TestViewWithComboBox and SelectedValue on the test view model.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4350 +/- ##
==========================================
+ Coverage 89.67% 89.85% +0.18%
==========================================
Files 253 253
Lines 9633 9638 +5
Branches 1473 1475 +2
==========================================
+ Hits 8638 8660 +22
+ Misses 753 734 -19
- Partials 242 244 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glennawatson
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix
What is the current behavior?
Closes #3921
What is the new behavior?
Use DependencyPropertyDescriptor.FromName to resolve dependency properties declared on base control types (via DependencyObjectType.SystemType) and return the descriptor's DependencyProperty when found; fall back to existing enumeration otherwise.
Add System.ComponentModel using and unit tests covering inherited property lookup (Selector.SelectedValue, TextBoxBase.IsReadOnly) and a BindWithValidation test for ComboBox.SelectedValue, plus a small TestViewWithComboBox and SelectedValue on the test view model.
What might this PR break?
Checklist
mainbranchAdditional information