fix: Winforms design mode detection regressed#4369
Merged
glennawatson merged 1 commit intoMay 29, 2026
Merged
Conversation
glennawatson
approved these changes
May 29, 2026
Contributor
|
SonarCloud failing is expecting, since you're not part of the organisation. So it's to protect the token. So once the CodeQL passes we can merge it in, which will be available for the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix #4368 and add a regression test.
What is the new behavior?
See description of #4358.
What is the current behavior?
See description of #4358.
What might this PR break?
See description of #4358.
Checklist
mainbranchAdditional information
In the original PR I didn't add a regression test because we can't run the Winforms designer in a test.
However, it turns out it's actually really easy to mock a site in design mode.