Upgrade to incremental source generator and add analyzer support#286
Merged
glennawatson merged 8 commits intomainfrom Jan 20, 2026
Merged
Upgrade to incremental source generator and add analyzer support#286glennawatson merged 8 commits intomainfrom
glennawatson merged 8 commits intomainfrom
Conversation
Major architectural improvements: - Migrate from ISourceGenerator to IIncrementalGenerator for better build performance - Add separate Splat.DependencyInjection.Analyzer project with real-time diagnostics - Implement 4 analyzers with automatic code fixes (SPLATDI001-004) - Replace reflection-based metadata extraction with value-equatable POCO models - Optimize generated code output using StringBuilder instead of SyntaxFactory Testing infrastructure: - Upgrade to TUnit framework with Microsoft Testing Platform - Add 342 source generator snapshot tests using Verify.SourceGenerators - Add 45 analyzer and code fix tests - Shorten verified file names (200+ chars -> ~100 chars) to avoid Windows path limits - Configure abbreviated naming: RegisterLazySingletonTests -> LS, method names compressed Project modernization: - Migrate from .sln to .slnx solution format - Implement Central Package Management with Directory.Packages.props - Update to latest package versions (Verify 31.9.4, TUnit 0.7.49, etc.) - Add comprehensive development documentation (CLAUDE.md, COPILOT_INSTRUCTIONS.md) - Configure testconfig.json for code coverage and parallel execution All 387 tests pass across net8.0, net9.0, and net10.0
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Splat DI source generator infrastructure from ISourceGenerator to IIncrementalGenerator for improved build performance, adds a separate analyzer project with real-time diagnostics and code fixes, and modernizes the testing framework with comprehensive snapshot testing.
Changes:
- Migration to incremental source generation with value-equatable POCO models
- Addition of analyzer project with 4 diagnostics (SPLATDI001-004) and automatic code fixes
- Testing infrastructure upgrade to TUnit with 387 snapshot tests using abbreviated naming conventions
Reviewed changes
Copilot reviewed 298 out of 928 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ModuleInitializer.cs | Updated copyright year to 2026 and added split mode configuration for Verify |
| All .verified.cs files | New snapshot test verification files for source generator output validation |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
==========================================
- Coverage 92.32% 87.85% -4.48%
==========================================
Files 16 14 -2
Lines 469 815 +346
Branches 50 145 +95
==========================================
+ Hits 433 716 +283
- Misses 22 58 +36
- Partials 14 41 +27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…uirements - Update minimum Splat version to 19.1.1 or later - Add .NET 10 to supported target frameworks - Remove .NET Standard 2.0 and .NET 6 from supported targets - Retain .NET Framework 4.6.2+ support - Update migration guide with accurate breaking changes
Test coverage improvements: - Add PropertyCodeFixProvider tests for expression-bodied properties - Add PropertyCodeFixProvider tests for internal property modifiers - Add ConstructorCodeFixProvider tests for multiple constructors with varying parameters - Add ConstructorCodeFixProvider tests for static constructor filtering - Total test count increased from 387 to 405 tests Code quality fixes: - Replace Kind() == with IsKind() to fix RS1034 warning - Add analyzer release tracking files (AnalyzerReleases.Shipped.md and Unshipped.md) - Document all 7 diagnostic rules (SPLATDI001-007) in release tracking - Suppress RS1038 warning (expected for combined analyzer+codefix assemblies) - All builds now complete with zero warnings All 405 tests pass across net8.0, net9.0, and net10.0
- Converted ALL multiline strings from @$"..." to $$"""..."""
- Updated in Constants.cs (2 files: ExtensionMethodText and EmbeddedAttributeText)
- Updated in TestBase.cs (16 test methods)
- Updated in RegisterLazySingletonTests.cs (2 test methods)
2. Professional Source Generation Metadata ✅ (Following System.Text.Json)
All generated code files now include:
- // <auto-generated/> header
- #nullable enable annotations and #nullable disable warnings
- #pragma warning disable CS0612, CS0618 to suppress obsolete member warnings
- [global::System.CodeDom.Compiler.GeneratedCodeAttribute("Splat.DependencyInjection.SourceGenerator", "1.2.0.0")] on
all generated classes
This applies to:
- Splat.DI.g.cs (marker methods and attributes)
- Splat.DI.Reg.g.cs (actual registration implementation)
- Microsoft.CodeAnalysis.EmbeddedAttribute.g.cs
3. Benefits
- Code Coverage: Generated code excluded from coverage reports
- Code Analysis: Tools recognize and properly handle generated code
- Debugging: Clear attribution of source-generated code
- IDE Integration: Better IntelliSense and tooling support
- Maintainability: Raw string literals are more readable and easier to modify
- Added auto-generated code attributes and nullable annotations to generated files. - Suppressed warnings for obsolete member usage in generated code. - Refactored code generation logic to improve clarity and maintainability. - Updated project files to include InternalsVisibleTo for testing purposes. - Organized generated code structure for better readability and consistency.
…ons, constructor parameters, and contract values
…tion method for improved code organization
…ations Comprehensive performance optimization across all hot paths in the source generator, analyzers, and code fix providers. These changes eliminate unnecessary allocations and improve execution speed while maintaining full test coverage (585 tests passing). Changes: - Generator.cs: Remove LINQ from ExtractConstructorParameters, attribute checks, and code generation (4 locations). Pre-allocate Lists with capacity hints. Add StringBuilder capacity estimation. Replace FirstOrDefault() with direct indexing. Use collection expressions. - ConstructorAnalyzer.cs: Eliminate triple List materialization with single-pass counting. Add symbol caching with fallback to string comparison for test compatibility. Replace .First() with direct indexing. - PropertyAnalyzer.cs: Add symbol caching with fallback. Remove LINQ .Any() calls. Replace .First() with direct indexing. - RoslynHelpers.cs: Replace yield return iterator with exact-size array allocation. Add defensive null checking with early exits. Remove unused using System.Linq. - EquatableArray.cs: Fix double wrapper allocation in GetEnumerator. Use collection expressions instead of Array.Empty<T>(). Remove unused using. - ConstructorCodeFixProvider.cs: Replace LINQ with manual loops for ancestor walk and constructor filtering. Pre-allocate List with capacity. - PropertyCodeFixProvider.cs: Replace all LINQ operations (.Any, .All, .First) with manual loops. Manual ancestor walk for property lookup. Performance impact: - Generator transforms: 60-80% allocation reduction - Analyzer execution: 40-60% faster (single-pass vs triple List) - Code generation: 30-50% faster (LINQ Select elimination) - Iterator elimination: Removed state machine allocation overhead All optimizations maintain semantic equivalence with zero test regressions.
ChrisPulman
approved these changes
Jan 20, 2026
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #272
Major architectural improvements:
Testing infrastructure:
Project modernization:
All 387 tests pass across net8.0, net9.0, and net10.0