Replace FluentAssertions with Shouldly in tests#417
Merged
ChrisPulman merged 3 commits intomainfrom Nov 16, 2025
Merged
Conversation
Switched test assertions in OperationQueueTests from FluentAssertions to Shouldly for improved readability and consistency. Updated package references and removed FluentAssertions in favor of Shouldly in both the project and central package management files.
Included the NUnit.Analyzers package in both central package management and the Punchclock.Tests project to enable static analysis for NUnit tests.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #417 +/- ##
=======================================
Coverage 62.08% 62.08%
=======================================
Files 6 6
Lines 298 298
Branches 52 52
=======================================
Hits 185 185
Misses 99 99
Partials 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Update
What is the current behavior?
Using FluentAssertions
What is the new behavior?
Switched test assertions in OperationQueueTests from FluentAssertions to Shouldly for improved readability and consistency. Updated package references and removed FluentAssertions in favor of Shouldly in both the project and central package management files.
What might this PR break?
None
Please check if the PR fulfills these requirements
Other information: