fix: Blazor WASM synchronous block#2116
Conversation
|
This bug for WASM have been introduced in de57efa with this description:
I'm not sure to understand the end goal of @ChrisPulman but the use of That said, reverting only the change line 973+ without reverting other changes can be hazardous. |
|
@begerard Thank you for the input, like I said to @glennawatson, I'm completely new to the codebase and im not 100% sure how my change affects other code, because this file is almost 2000 lines long. I traced it from the other side and understood the issue with the deadlock. It fixed the problem primarily, maybe there are better ways to approach this. You can of course take my changes as a start to do a better fix. Would it be helpful to maybe identify the use cases and split up this file, so it is more maintainable? |
|
I will get @ChrisPulman to review it, but looks good to me. He's more onboard with the latest refit changes of late. |
What kind of change does this PR introduce?
Bug fix
What is the new behavior?
This PR should fix #2115
What is the current behavior?
The version 11.0.0 introduced a blocking call which breaks using refit in single threaded environments like blazor WASM.
What might this PR break?
None
Checklist
mainbranchAdditional information