Skip to content

test(from): comment out test that dtslint is confused about #4516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benlesh merged 3 commits into from
Jan 30, 2019
Merged

test(from): comment out test that dtslint is confused about #4516

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40ae39f
test(from): comment out test that dtslint is confused about
benlesh Jan 30, 2019
a069451
prevent dtslint from detecting unused $ExpectType
benlesh Jan 30, 2019
dcb20c5
Add link to github issue on dtslint
benlesh Jan 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions spec-dtslint/observables/from-spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,21 @@ it('should accept an array of Observables', () => {
const o = from([of(1), of(2), of(3)]); // $ExpectType Observable<Observable<number>>
});

it('should accept an array of Inputs', () => {
const iterable = (function*() {
yield 42;
}());
// TODO(benlesh): enable this test, once the issue is resolved upstream (https://github.com/Microsoft/dtslint/issues/191)

const o = from([of(1), ['test'], iterable]); // $ExpectType Observable<IterableIterator<number> | Observable<number> | string[]>
});
// NOTE: It appears to be working, it's just that dtslint sometimes says it wants
// Observable<IterableIterator<number> | Observable<number> | string[]>
// and if you switch it to that, it wants
// Observable<Observable<number> | IterableIterator<number> | string[]>
// and vica versa.

// it('should accept an array of Inputs', () => {
// const iterable = (function*() {
// yield 42;
// }());

// const o = from([of(1), ['test'], iterable]); // $__TODO__ExpectType Observable<IterableIterator<number> | Observable<number> | string[]>
// });

it('should support scheduler', () => {
const a = from([1, 2, 3], animationFrameScheduler); // $ExpectType Observable<number>
Expand Down