Skip to content

Sync with react.dev @ fcd00068#49

Merged
zubialevich merged 14 commits intomainfrom
sync-fcd00068
Nov 13, 2023
Merged

Sync with react.dev @ fcd00068#49
zubialevich merged 14 commits intomainfrom
sync-fcd00068

Conversation

@react-translations-bot
Copy link
Copy Markdown
Collaborator

@react-translations-bot react-translations-bot commented Nov 13, 2023 •
edited by zubialevich
Loading

This PR was automatically generated.

Merge changes from react.dev at fcd0006

The following files have conflicts and may need new translations:

Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.

DO NOT SQUASH MERGE THIS PULL REQUEST!

Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.

smikitky and others added 12 commits November 6, 2023 14:09
@smikitky
Remove "canary: true" from useTransition in Sidebar (#6411)
55b9e04
@smikitky
Fix style in React Reference Overview (#6410)
617065b
@oxcened
fix Illustration and IllustrationBlock alt color on dark mode (#5981)
8727204
@Huxpro
Captailize Server Action (#6417)
42ca996 
Summary of changes:
"Server Action", like "Effect", is a React-specific notion
that would be benefited from captailization to be distinguished
from its genertic meaning.

It seems like [Next doc](https://nextjs.org/docs/app/api-reference/functions/server-actions)
has also adopted such connventions and we should probably do the same.

Co-authored-by: xuan.huang <xuan.huang@bytedance.com>
@Huxpro
Capitalize Client/Server Component (#6418)
292e55d 
Summary of changes:
following <reactjs/react.dev#6417>

Co-authored-by: xuan.huang <xuan.huang@bytedance.com>
@Huxpro
Capitalize Client in "client modules" (#6419)
c5a2e15 
Summary of changes:
See <reactjs/react.dev#6417>

Co-authored-by: xuan.huang <xuan.huang@bytedance.com>
@kmiddleton14
Check for value before passing to gtag (#6415)
721479b
@kmiddleton14
Update event label and value name (#6421)
eeb0979
@kmiddleton14
Fix useOptimistic demo bug (#6422)
49ebed1
@lunaleaps
Add space for canary title (#6416)
44f442d 
Co-authored-by: Luna Wei <luwe@fb.com>
@Huxpro
Capitalize word "Hook" (#6424)
fcd0006 
Summary of changes:
See <reactjs/react.dev#6417>.

There is one exception though. The error message
“Rendered fewer hooks than expected” from React is indeed "hooks"
so I kept as-is. Shall we change the error message from React?

Co-authored-by: xuan.huang <xuan.huang@bytedance.com>
@react-translations-bot
merging all conflicts
204e111
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 13, 2023

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 77.69 KB (🟡 +22 B) 181.43 KB
/500 77.68 KB (🟡 +22 B) 181.43 KB
/[[...markdownPath]] 79.31 KB (🟡 +20 B) 183.05 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@zubialevich zubialevich merged commit 25bb4d3 into main Nov 13, 2023
@zubialevich zubialevich deleted the sync-fcd00068 branch November 13, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@react-translations-bot @zubialevich @smikitky @oxcened @Huxpro @kmiddleton14 @lunaleaps