Skip to content

Conversation

@lencioni
Copy link
Contributor

This pull request contains a couple of small improvements to the readme:

  • hard wrap at 80 characters for readability
  • fix incorrect path when talking about components.js

@zpao
Copy link
Member

zpao commented Apr 24, 2014

Can you sign the cla (https://code.facebook.com/cla)?

(I personally don't care for the 80 character change BUT I'll let @JakubMal make that call)

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@jtmalinowski
Copy link
Collaborator

Hi, if https://github.com/rails/rails can be of any indication, they don't hard wrap in their README.md, or rather wrap a bit, but it looks like they don't care, also I looked at a few other gems, and they don't wrap too, btw I think any text editor should be able to do this for you.

You are right about the link, so it would be best if you could just remove b833641 and we're ready to go!

Thanks!

The example code looks like it will glob the files in
app/assets/javascripts/components, but the paragraph says that it will
glob the files in app/assets/components. I believe that this is a
mistake, so this commit fixes this problem.
@lencioni
Copy link
Contributor Author

Sure thing, all done.

@jtmalinowski
Copy link
Collaborator

What we need yet is your CLA :) It's kind of ridiculous for a change this small, but I can't help.

@lencioni
Copy link
Contributor Author

lencioni commented May 5, 2014

We have submitted the corporate CLA, so we should be good to go there. Let me know if there is anything else I need to do.

@zpao
Copy link
Member

zpao commented May 5, 2014

I don't see Causes under the organization CLAs. Let me know if it's actually a different name or if I should go bug somebody who works on that tool to make sure it didn't get lost.

@lencioni
Copy link
Contributor Author

lencioni commented May 5, 2014

I believe that it was submitted with the company name "Causes". Let me know if any additional information would be helpful.

@zpao zpao added CLA signed and removed CLA needed labels May 6, 2014
@zpao
Copy link
Member

zpao commented May 6, 2014

All good on the CLA front, feel free to merge when ready @JakubMal

jtmalinowski added a commit that referenced this pull request May 21, 2014
@jtmalinowski jtmalinowski merged commit 8b0a799 into reactjs:master May 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants