-
Notifications
You must be signed in to change notification settings - Fork 750
Improve readme #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve readme #41
Conversation
|
Can you sign the cla (https://code.facebook.com/cla)? (I personally don't care for the 80 character change BUT I'll let @JakubMal make that call) |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Hi, if https://github.com/rails/rails can be of any indication, they don't hard wrap in their You are right about the link, so it would be best if you could just remove Thanks! |
The example code looks like it will glob the files in app/assets/javascripts/components, but the paragraph says that it will glob the files in app/assets/components. I believe that this is a mistake, so this commit fixes this problem.
|
Sure thing, all done. |
|
What we need yet is your CLA :) It's kind of ridiculous for a change this small, but I can't help. |
|
We have submitted the corporate CLA, so we should be good to go there. Let me know if there is anything else I need to do. |
|
I don't see Causes under the organization CLAs. Let me know if it's actually a different name or if I should go bug somebody who works on that tool to make sure it didn't get lost. |
|
I believe that it was submitted with the company name "Causes". Let me know if any additional information would be helpful. |
|
All good on the CLA front, feel free to merge when ready @JakubMal |
This pull request contains a couple of small improvements to the readme: