add preprocessor to handle comment directives in sprocket 3.7.0+ , fixes #580

[seuros]

can you please check this PR @forelabs ?

[forelabs]

• no comment in compiled asset
• comment converted into required component code

works like a charm!

[rmosolgo]

@seuros what do you think about adding a test case for this?

I'm trying to see if I understand ... since we're defining a new mime type in react-rails, we also have to tell Sprockets to preprocess //= requires in this new mime type, right? It seems like we should add a test case to cover //= requires in the new mime type.

Maybe you could add a new directory, assets/javascripts/require_test/, and make a few files, then add a .jsx file which requires them, eg

// app/assets/javascripts/require_test/jsx_require_test.jsx
//= require ./jsx_require_child_1
//= require ./jsx_require_child_2

<div className="own-div" />

Then, fetch the "compiled" asset and make sure it includes all required content:

jsx_require_asset = Rails.application.assets["require_test/jsx_require_test"].to_s 
# Make sure the asset has required content & own content:
assert_includes jsx_require_asset, jsx_require_child_1_content
assert_includes jsx_require_asset, jsx_require_child_w_content
assert_includes jsx_require_asset, own_content 

Or, another way to make sure that this works the way we expect in the future?

[seuros]

@rmosolgo Sure thing.

[rmosolgo]

should be test "executes //= require directives" do ?

[seuros]

@rmosolgo we can remove the work in progress in sprocket 4 now.

[rmosolgo]

🎉 thanks, i'll merge and ship 1.8.2 pronto.

[rmosolgo]

removed the sprockets 4 note in 5049473

[rmosolgo]

🚢 1.8.2 🎊 thanks again!