fix(ReactUjs): Fixed variable typo in findDOMNodes

[tannermares]

Why this was needed

Looks like findDOMNodes has a typo in the argument name here. selector should be searchSelector. Since the incorrect value is used ALL components are unmounted when findDOMNodes is called from unmountComponents

How I fixed it

Updated argument name from selector to searchSelector here

I adding a spec. I'm not familiar with MiniTest or server side rendering and tried to implement the failure in the simplest way possible.

I believe the failing specs are from JS warnings the rake react:update caused. Looks like maybe the createClass deprecation? Should I not rake react:update?

Any suggestions on that front and I'll gladly implement. :)

Note: This is my first contribution and couldn't find a "how to contribute" section. I apologize for any missing steps or documentation.

[rmosolgo]

I think you're right about react:update causing the issues. This library isn't ready for the latest version!

I don't want to merge the failing specs, but either of these three is ok with me:

• Correct the typo in react_ujs/index but don't modify the test suite
• Correct the typo and figure out how to make the proper test case pass
• Correct the typo & test it, and update React and make the tests pass (shudder)

Does one of those sound good to you?

[tannermares]

@rmosolgo updated

[rmosolgo]

🤘 Thanks! I'm going to try to get #697 in before a release tomorrow morning.

[rmosolgo]

🚢 in 2.1.0!