Skip to content

Conversation

@BookOfGreg
Copy link
Member

Summary

Same as #962 with test fixes from reactjs/react-rails master.

Summoning @HorizonShadow

@joshleblanc
Copy link

👍

Still can't overcome the gyp errors locally, but I was using my fork for the project I was working on 2 months ago and don't recall running into issues.

@BookOfGreg
Copy link
Member Author

@HorizonShadow I've seen some odd behaviour with NPM/Yarn failing to keep deps properly.
#979 (comment)
Could this be related or something different?

@BookOfGreg BookOfGreg merged commit 4dbcd67 into reactjs:master Jul 27, 2019
@BookOfGreg BookOfGreg deleted the enhanced-turbolinks-support branch July 27, 2019 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants