Skip to content

Simplify <Link> active semantics #3231

@taion

Description

@taion

Prerequisites: #3158, #3172

Once we merge #3158, we'll be able to dramatically simplify the active checking for index-only links – that check will just be a comparison of the link to the path name, with a special case for handling trailing slashes (as the pathname will be canonical outside of the trailing slash).

For consistency, we should consider also updating the semantics on non-index links to just do a prefix check, once we also resolve #3172. Given issues like #3230 (and many related ones), users seem to be confused with the current behavior of path active status calculation. Also, this will dramatically improve #1873, as it will let us avoid running a full route match just to determine if a link path is active.

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature-requestUsed to close PRs that haven't gone through/been accepted the Proposal process yet

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions