-
Notifications
You must be signed in to change notification settings - Fork 648
chore: Bump deps #611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump deps #611
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! ❤️
Two problems I spotted:
yarn storybookfails becauserules.js.inlineCssfrom webpack-atoms is no longer a function- I think this is a good opportunity to revisit two tests in
TransitionGroup-tests.jswhich define theChildcomponent- these tests seem invalid because
componentWillEnterandcomponentWillLeavedon't exist 🤷
- these tests seem invalid because
|
d'oh |
|
@silvenon okay, the storybook was screwed up more broadly because the transitions themselves were disabled. i fixed it and modernized some of the code. i also took out those 2 stale test cases |
silvenon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 👌 Nice an modern ❤️
|
@taion @silvenon My suggestion would be to revert back because they are listed also in |
|
The peer dependencies use a |
I also thought this on What I mean above is that for example I'm working on a feature in |
|
I think it's best to set up a sanity test on CI with lowest supported React version. |
|
🎉 This PR is included in version 4.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.