Skip to content
This repository was archived by the owner on Jul 19, 2019. It is now read-only.

Conversation

@cesine
Copy link

@cesine cesine commented Sep 11, 2015

The tutorial says

React is all about modular, composable components. For our comment box example, we'll have the following component structure:

- CommentBox
  - CommentList
    - Comment
  - CommentForm

This PR just renames the example.js to clarify that this is a normal React component.

(references: I found an example of an app using React components which shows they usually go in a components dir https://facebook.github.io/flux/docs/todo-list.html#source-code-structure starting off the tutorial like this would help for learners to learn react component creation best practices)

cesine added a commit to cesine/react that referenced this pull request Sep 11, 2015
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@cesine
Copy link
Author

cesine commented Sep 11, 2015

done :)

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@sophiebits
Copy link
Member

I don't think we'll do this but we'll keep this sort of change in mind as we update the tutorial.

@sophiebits sophiebits closed this Sep 24, 2015
@cesine
Copy link
Author

cesine commented Sep 25, 2015

awesome :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants