-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Extended JS environment requirements polyfills list with a promise #1553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended JS environment requirements polyfills list with a promise #1553
Conversation
|
👍thanks |
|
Deploy preview for reactjs ready! Built with commit 8db2e3e |
|
We should probably explain this a bit more, as I don’t think Promise is strictly required unless you’re using Internally React models it as “thenable”, which could be a regular object with a cc @gaearon |
|
@aweary @gaearon Would It be correct to add after this sentence |
|
I reverted for now to avoid confusion (#1554) but ideally we'd add a small note to the |
|
@alexkrolick for future reference, "JS requirements" can't change without a major version. If we add requirements midway it looks like a breaking change. We should avoid this kind of confusion. |
|
Definitely need to add a note to the lazy docs. Otherwise technically it is broken without a polyfill. It's also in the IE11 polyfill for CRA: https://github.com/facebook/create-react-app/blob/master/packages/react-app-polyfill/ie11.js See #1556 |
IE11 needs a Promise polyfill for React 16.7. (not only Set and Map polyfills)
If you are using Lazy and Suspense feature, IE throws a null error. In 'readLazyComponentType' function implementation.
#1552