Skip to content

removed old "early time for hooks" note#4321

Merged
gaearon merged 1 commit intoreactjs:mainfrom
uulaal:main
Feb 11, 2022
Merged

removed old "early time for hooks" note#4321
gaearon merged 1 commit intoreactjs:mainfrom
uulaal:main

Conversation

@uulaal
Copy link
Copy Markdown
Contributor

@uulaal uulaal commented Feb 10, 2022

This note was added in 2019 and it was really confusing to see it in 2022. My friend, who just started learning react, texted me with a question "is it ok to use hooks?" referring to this note. It might be really confusing for beginners, because hooks already became a standard

@facebook-github-bot
Copy link
Copy Markdown
Collaborator

Hi @uulaal!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@github-actions
Copy link
Copy Markdown

Size Changes

Details

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

@facebook-github-bot
Copy link
Copy Markdown
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@gaearon gaearon merged commit f20da4c into reactjs:main Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants