Conversation
Size ChangesDetails📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! One Hundred Eighty-three Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview
In #4328 we have restructured 1-2-3 sections into highlight in the inline text. However, the 1-2-3 labels no longer reflect any semantic ordering that we want to convey.
This becomes more obvious if we try to use it with even slightly less structured examples:
In code,
useRef([3] 0)looks strange and distracting. There was anecdotal feedback from quite a few people that labels interfere with the flow of text.While we could minimize their usage, it feels like maybe there's an opportunity to refine this.
This PR changes it to boxes like this:
It is not ideal that they appear a bit like links, but I couldn't find a clearer pattern that feels as legible without sacrificing the feature itself. Maybe if somebody has a clever idea, we can try that. But this feels like a step forward to me. It's possible we could actually add some kind of click/tap action if we wanted to.
One concern with dropping numbers may be that this decreases legibility for colorblind users. I'm not sure how helpful the numbers were in the last iteration. I ran a few tests with a simulator, and colors alone appeared distinguishable enough in all cases except Tritanomaly, where the green and blue we use appeared similar. This is inessential information so I don't think it's blocking but it would be nice if we could swap out the green color for something that isn't ambiguous with blue. I've tried a few other options but they were worse for people with more common forms.
Potential follow-ups could be