Skip to content

Change button text "Click me" to something else#4697

Merged
gaearon merged 1 commit intoreactjs:mainfrom
surjithctly:patch-1
May 26, 2022
Merged

Change button text "Click me" to something else#4697
gaearon merged 1 commit intoreactjs:mainfrom
surjithctly:patch-1

Conversation

@surjithctly
Copy link
Contributor

The Text "Click me" in the button confuses first-time users because it forces them to actually click on the button in the live demo but it does nothing. By changing the text, we can control the user behavior as they don't expect anything on that click.

The Text "Click me" in the button confuses first-time users because it forces them to actually click on the button in the live demo but it does nothing. By changing the text, we can control the user behavior as they don't expect anything on that click.
@facebook-github-bot
Copy link
Collaborator

Hi @surjithctly!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@github-actions
Copy link

Size Changes

Details

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/learn 53.74 KB (🟡 +7 B) 138.31 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@gaearon
Copy link
Member

gaearon commented May 26, 2022

Sure, sounds good

@gaearon gaearon merged commit c209465 into reactjs:main May 26, 2022
@surjithctly surjithctly deleted the patch-1 branch May 26, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants