Skip to content

Add github repo link in the footer#5204

Merged
eps1lon merged 2 commits intoreactjs:mainfrom
arafatiqbal:ai/add-github-in-footer
Oct 31, 2022
Merged

Add github repo link in the footer#5204
eps1lon merged 2 commits intoreactjs:mainfrom
arafatiqbal:ai/add-github-in-footer

Conversation

@arafatiqbal
Copy link
Contributor

This adds the GitHub repo link in the footer, so it's easier to find, navigate to, and contribute

image

Issue #5203

@github-actions
Copy link

github-actions bot commented Oct 24, 2022

Size Changes

Details

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 42.44 KB (🟡 +287 B) 131.46 KB
/500 42.42 KB (🟡 +285 B) 131.43 KB
/[[...markdownPath]] 42.5 KB (🟡 +286 B) 131.52 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me but the misalignment is a bit unfortunate. Can you fix it to ensure these icons have are centered on the same horizontal axis visually?
Screenshot from 2022-10-29 10-24-48

@eps1lon eps1lon linked an issue Oct 29, 2022 that may be closed by this pull request
@facebook-github-bot
Copy link
Collaborator

Hi @arafatiqbal!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@arafatiqbal
Copy link
Contributor Author

@eps1lon Good catch, did not see that at all. Updated the svg to match the facebook one.
image

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@arafatiqbal arafatiqbal requested a review from eps1lon October 29, 2022 19:21
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eps1lon eps1lon merged commit 751a13f into reactjs:main Oct 31, 2022
@arafatiqbal arafatiqbal deleted the ai/add-github-in-footer branch October 31, 2022 20:01
@gaearon
Copy link
Member

gaearon commented Nov 11, 2022

This seems confusing to me.

The footer is for React itself, not for the docs. So the link should go to the React repo.

Yes, we need a link to the docs repo — but that's a separate and unrelated issue. It shouldn't go in the footer. We have an idea for where it should go but haven't prioritized that yet.

@gaearon
Copy link
Member

gaearon commented Nov 11, 2022

changed via 06ae637

@arafatiqbal
Copy link
Contributor Author

Thank you for clarifying @gaearon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Beta] Include a github icon link to this repo in the footer

4 participants