Forgotten import statement for createElement
#5601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `createElement` in the import statement since it was used within the code snippet but was not imported.
Collaborator
|
Hi @MarkE16! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Size Changes📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 This PR introduced no changes to the javascript bundle 🙌 |
Collaborator
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
gaearon
pushed a commit
that referenced
this pull request
Feb 21, 2023
Added `createElement` in the import statement since it was used within the code snippet but was not imported.
gaearon
added a commit
that referenced
this pull request
Mar 16, 2023
* twk * more * twkg * bla * search bar, blog, misc polish * fixes * polish * fixes * polish * adding back select * change order on mobile * fixes * search fix * fix * make select chevron clickable * add isLoading boolean to example4 * wip * tweak * wip * rewire * wip * tweaks * wip * wip * twk * content * twk * twk * twk * fix * wip * adding community marquee * fix * polish * polish * optimize img * images * 8 images * stuff * swap * words * making the button fun * slightly more subtle * checking in OG images * tweak * words * lol * improve blog section * algolia.css improvements * words * fix * wat * Revert "8 images" This reverts commit 31c69ed. * wip * 8 images * add new badge and bottom align date * change icon * rm new for now * change icon * img * Revert "change icon" This reverts commit a2758b9. * mobile fixes for marquee * like button tweaks * polish * en dash * adding ctas * clean up images, wire up og * more subtle search * smaller divider * remove search shadow * cta * cleanup * cta * refactor * Revert "remove search shadow" This reverts commit a4e0d97. * Revert "smaller divider" This reverts commit 0996b5b. * Revert "more subtle search" This reverts commit 734b5d7. * scroll topg * tweaks * tweaks * cta * words * words * typo * batch of visual polish / touches * tweak * add subheader component * algolia css fixes * border * tweaks * tweak * polish * tweak * gradient text * flip gradient text * grad * gr * tweak * swap * reorder * rm * caps * updated fonts * top nav tweak * tweak * more rounded left/right bars * `Conferences`: Move past conferences to past section (#5544) * Move past conferences to past section * Update ordering for past conferences, most recent first * added React Nexus to conference list in beta docs (#5552) * Fix typo in flushSync docs (#5589) * fix: change experimental_useEvent to experimental_useEffectEvent in escape-hatches.md (#5573) * Fix typo in forwardRef Beta Docs Reference (#5570) * Fixed wrong debug command (#5596) * Forgotten import statement for `createElement` (#5601) Added `createElement` in the import statement since it was used within the code snippet but was not imported. * docs: fix `react-hooks/exhaustive-dependencies` typo (#5605) The rule is `exhaustive-deps`, not `exhaustive-dependencies`. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> * fix: correct prev link in `hello-world` (#5595) * fix typo (#5611) * Fix fonts * Update .gitignore * more preload * meh * fixes * fix missing * increase width * words * twl * put real images * blog fixes * all imgs * read more button * add react text on large screens * misc polish, new icons, footer tweaks * change pitfall icon * fix * add gradient * fix * blog updates * scroll lock * fit * blog tweaks * display * smaller images * tweaks * separate component * fix some hanging words * tinier images * even tinier I guess * small a11y fixes * minor * add experimental_ * check in images * compress * lazy load community * fix * outline * svg conf bgs * crush images * reorder images for balance * bg in case images don't load * RN CTA target=_blank * refactor * rmfixed * eager lazyg * dimensions * add some content vis * lock * detect scroll without event * ts * check * Revert "check" This reverts commit c404892. * remove feedback on mobile * just "Go truly native" * anim-fix * fix stretching * tsc * more scroll perf * mobile nav fixes * z-index fix * z * next/link for CTA for scroll restoration and client-side nav * logo symmetry * curly quotes * fix * fix wrapping on mobile on platform section * highlights * polish * tweaks * fix safari * adjust outline above SearchInput * symmetry * spacing * tweak * nbsp * orphans * fix * no match * oops * extract posts * fixnav * let them play a bit more * don't animate until hydration * fix boundaries calc * fix og images * 404 * twks * fix likes * less aggro lock * no initial fadein * gpu * fix sticky * more opt * clearer * twk * wip * wip * wip * wip * post * tweak shadows * nav animation * twk * fix * fix grid alignment * fix * animation tweak * wip * stuff * recommend to * drop spin * link * edits * edit * twk * clarify * twk * twk * twk * link * edits * dates * fix * edits * words * fixes * refactor * tweak * twk * custom setups * expo --------- Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Co-authored-by: Dan Abramov <dan.abramov@gmail.com> Co-authored-by: D <dan.lebo@me.com> Co-authored-by: Sophie Alpert <git@sophiebits.com> Co-authored-by: Nick Foden <nickfoden@gmail.com> Co-authored-by: Kiran Abburi <akiran@users.noreply.github.com> Co-authored-by: Minh Nguyen <2852660+NMinhNguyen@users.noreply.github.com> Co-authored-by: LamNVQ <97967630+DawnGate@users.noreply.github.com> Co-authored-by: Hyunseung Lee <hyunseunglee2008@gmail.com> Co-authored-by: BIKI DAS <bikid475@gmail.com> Co-authored-by: Mark Evola <76978800+MarkE16@users.noreply.github.com> Co-authored-by: Eng Zer Jun <engzerjun@gmail.com> Co-authored-by: Xavi Lee <awxiaoxian2020@163.com> Co-authored-by: 이동현 <ldh19971027@gmail.com> Co-authored-by: Dan Abramov <dan.abramov@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
createElementin the import statement since it was used within the code snippet but was not imported in the API Reference forisValidElement.