Skip to content

Conversation

@oliviertassinari
Copy link
Contributor

@oliviertassinari oliviertassinari commented Mar 17, 2023

The current value is broken, the header has the .h-16 class name which equals to 4rem.

Before
https://react.dev/reference/react/useDeferredValue#showing-stale-content-while-fresh-content-is-loading

Screenshot 2023-03-18 at 00 46 41

After
https://beta-reactjs-d66fwm2n6-fbopensource.vercel.app/reference/react/useDeferredValue#showing-stale-content-while-fresh-content-is-loading

Screenshot 2023-03-18 at 00 46 53


For this test, I used:

Screenshot 2023-03-18 at 00 48 03

but it equally improve the experience with the default value (16px for the default font size)

The current value is broken, the header has the `.h-16` class name which equals to 4rem.
@github-actions
Copy link

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 92.94 KB (🟡 +9 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@gaearon gaearon merged commit 50551f8 into reactjs:main Mar 18, 2023
@gaearon
Copy link
Member

gaearon commented Mar 18, 2023

Thanks! Don't know how this happened. I thought I fixed this before. :P

@oliviertassinari oliviertassinari deleted the patch-1 branch March 18, 2023 20:15
@oliviertassinari
Copy link
Contributor Author

I was working on updating all the links in https://mui.com/ this weekend from the old to the new React docs, happy to have solved this small annoyance :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants