Skip to content

Remove unused variable nextId from updating arrays in state lesson#6473

Closed
kprakhar wants to merge 1 commit intoreactjs:mainfrom
kprakhar:fix/remove-unused-variable
Closed

Remove unused variable nextId from updating arrays in state lesson#6473
kprakhar wants to merge 1 commit intoreactjs:mainfrom
kprakhar:fix/remove-unused-variable

Conversation

@kprakhar
Copy link
Copy Markdown

@kprakhar kprakhar commented Dec 9, 2023

Issue: In Updating Arrays in State lesson in one of the code example there is a unused variable called nextId.

Fix: As it's not required, I've removed it.

Before:
Screenshot 2023-12-09 at 11 45 04 AM

After:
Screenshot 2023-12-09 at 11 46 51 AM

@facebook-github-bot
Copy link
Copy Markdown
Collaborator

Hi @kprakhar!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 9, 2023

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@kprakhar kprakhar changed the title Remove unused variable nextId from updating arrays in state lesson Remove unused variable nextId from updating arrays in state lesson[#6405] Dec 9, 2023
@kprakhar kprakhar changed the title Remove unused variable nextId from updating arrays in state lesson[#6405] [#6405] Remove unused variable nextId from updating arrays in state lesson Dec 9, 2023
@kprakhar kprakhar changed the title [#6405] Remove unused variable nextId from updating arrays in state lesson [6405] Remove unused variable nextId from updating arrays in state lesson Dec 9, 2023
@kprakhar kprakhar changed the title [6405] Remove unused variable nextId from updating arrays in state lesson Remove unused variable nextId from updating arrays in state lesson Dec 9, 2023
@facebook-github-bot
Copy link
Copy Markdown
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Copy Markdown
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@BartoszKlonowski
Copy link
Copy Markdown
Collaborator

Hello @kprakhar!
Thank you for creating the PR, however, there was a PR with the fix already linked to this issue.
Let me close this PR as it is a duplicate of #6470 already merged and issue is already closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants