Mention getSnapshotBeforeUpdate should return. #930
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
toshi38
force-pushed
the
stelau/getSnapshotBeforeUpdate-return-value
branch
from
c361ee2 to
af23dbb
Compare
|
Deploy preview for reactjs ready! Built with commit c361ee21f981f1b1a0f41240b39647f5743ed486 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Deploy preview for reactjs ready! Built with commit b714479 |
|
Seems to break on something unrelated to my changes, can someone retrigger this? ... or do you prefer I force push to retrigger? |
If getSnapshotBeforeUpdate does not return a snapshot value or null it will cause a warning. Document that it should return this value.
toshi38
force-pushed
the
stelau/getSnapshotBeforeUpdate-return-value
branch
from
af23dbb to
b714479
Compare
|
Looks good, thanks. |
4 participants
If getSnapshotBeforeUpdate does not return a snapshot value or null
it will cause a warning. Document that it should return this value.