Skip to content

Specify articleLayout.container.flexDirection to 'column'#1414

Merged
gaearon merged 1 commit into
reactjs:masterfrom
wongmjane:wongmjane-patch1
Nov 20, 2018
Merged

Specify articleLayout.container.flexDirection to 'column'#1414
gaearon merged 1 commit into
reactjs:masterfrom
wongmjane:wongmjane-patch1

Conversation

@wongmjane

Copy link
Copy Markdown
Contributor

articleLayout.container.flexDirection is supposed to be column direction since the layout is vertical.

Fixes #1404

@wongmjane

Copy link
Copy Markdown
Contributor Author

The line wrapping issue in #1404 no longer occurs on Firefox (Android) 63.0.2 with this patch.

1542711705

@reactjs-bot

Copy link
Copy Markdown

Deploy preview for reactjs ready!

Built with commit 9566eab

https://deploy-preview-1414--reactjs.netlify.com

@wongmjane wongmjane changed the title Specify articleLayout.container to flex in column direction Specify articleLayout.container.flexDirection to 'column' Nov 20, 2018
@gaearon gaearon merged commit d0718a3 into reactjs:master Nov 20, 2018
@gaearon

gaearon commented Nov 20, 2018

Copy link
Copy Markdown
Member

Seems legit. Thanks!

@gaearon

gaearon commented Nov 20, 2018

Copy link
Copy Markdown
Member

Seems like this breaks desktop. Reverting :P

@wongmjane

Copy link
Copy Markdown
Contributor Author

Seems like this breaks desktop. Reverting :P

Second attempt #1416 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants