Skip to content

Updates CrowdIn configuration to use /docs/lang/folder/file.md#301

Merged
bvaughn merged 1 commit into
reactjs:masterfrom
ericnakagawa:master
Nov 18, 2017
Merged

Updates CrowdIn configuration to use /docs/lang/folder/file.md#301
bvaughn merged 1 commit into
reactjs:masterfrom
ericnakagawa:master

Conversation

@ericnakagawa

Copy link
Copy Markdown
Contributor

This PR changes where localized files, downloaded from CrowdIn, are output.

To verify you can run crowdin upload and download locally from reacjs.org folder:

crowdin --config crowdin.yaml upload sources --auto-update -b test-17
crowdin --config crowdin.yaml download -b test-17

The files will then be available in reactjs.org/docs/*.

@reactjs-bot

Copy link
Copy Markdown

Deploy preview ready!

Built with commit 1fe0a1b

https://deploy-preview-301--reactjs.netlify.com

@bvaughn bvaughn merged commit f8ec389 into reactjs:master Nov 18, 2017
@bvaughn

bvaughn commented Nov 18, 2017

Copy link
Copy Markdown
Contributor

Thanks Eric.

@bvaughn

bvaughn commented Nov 18, 2017

Copy link
Copy Markdown
Contributor

cc @clemmy We'll want to merge this into our crowdin integration branch.

@clemmy clemmy mentioned this pull request Nov 20, 2017
@clemmy

clemmy commented Nov 20, 2017

Copy link
Copy Markdown
Contributor

Yup, we can probably just merge master in. I'll submit a PR.

@clemmy

clemmy commented Nov 20, 2017

Copy link
Copy Markdown
Contributor

@ericnakagawa I built and downloaded the translation zip, and I see 3 folders after extracting: master, test-16, and test-17. Looking at the contents of each one: master looks recursive, which isn't what we want, and the contents of test-17 seem to be more aligned with what I was expecting, but it only has blog and docs folder underneath a locale directory. (Also the contents are in English). Is this what is expected, or am I doing something wrong?

@clemmy

clemmy commented Nov 20, 2017

Copy link
Copy Markdown
Contributor

screen shot 2017-11-19 at 8 54 46 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants