Skip to content

Fix community anchor link to make it clear on all desktop/laptop screens#3134

Merged
rickhanlonii merged 1 commit into
reactjs:masterfrom
RusimbiPatrick:fix-community-anchor-link
Jul 26, 2020
Merged

Fix community anchor link to make it clear on all desktop/laptop screens#3134
rickhanlonii merged 1 commit into
reactjs:masterfrom
RusimbiPatrick:fix-community-anchor-link

Conversation

@RusimbiPatrick

@RusimbiPatrick RusimbiPatrick commented Jul 23, 2020

Copy link
Copy Markdown
Contributor

This PR Fixes Issue: #3121

Screenshots

Before

Screenshot from 2020-07-23 03-42-04
Screenshot from 2020-07-23 03-41-55
Screenshot from 2020-07-23 03-41-49

After

Screenshot from 2020-07-23 03-43-41
Screenshot from 2020-07-23 03-33-46
Screenshot from 2020-07-23 03-33-39
Screenshot from 2020-07-23 03-33-31

@facebook-github-bot

Copy link
Copy Markdown
Collaborator

Hi @RusimbiP!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

Copy link
Copy Markdown
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@rickhanlonii rickhanlonii left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rickhanlonii rickhanlonii merged commit bb8b014 into reactjs:master Jul 26, 2020
@rickhanlonii

Copy link
Copy Markdown
Member

Thanks for your first React contribution @RusimbiP!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants