Skip to content

🔒 [security] Fix Reverse Tabnabbing Vulnerability via target='_blank' #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunnylqm merged 1 commit into from
Apr 5, 2026
Merged

🔒 [security] Fix Reverse Tabnabbing Vulnerability via target='_blank' #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/main-layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ const ExtLink = ({ children, href }: ExtLinkProps) => (
href={href}
target="_blank"
// onClick={(e) => e.stopPropagation()}
rel="noreferrer"
rel="noopener noreferrer"
>
{children}
</a>
Expand Down
2 changes: 1 addition & 1 deletion src/components/sider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ const SiderMenu = ({ selectedKeys, onNavigate }: SiderMenuProps) => {
7日平均剩余次数：{user.last7dAvg?.toLocaleString()} 次
</div>
<div className="text-xs mt-2 text-center">
<a target="_blank" href={PRICING_LINK} rel="noreferrer">
<a target="_blank" href={PRICING_LINK} rel="noopener noreferrer">
{quota?.title}
</a>
可用: {pvQuota?.toLocaleString()} 次/每日
Expand Down
2 changes: 1 addition & 1 deletion src/pages/api-tokens.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ function ApiTokensPage() {
<a
target="_blank"
href="https://update.reactnative.cn/api/openapi"
rel="noopener"
rel="noopener noreferrer"
>
Pushy API
</a>
Expand Down
2 changes: 1 addition & 1 deletion src/pages/manage/components/commit.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export const Commit = ({ commit }: { commit?: Commit }) => {
className="text-xs"
href={url}
target="_blank"
rel="noreferrer"
rel="noopener noreferrer"
>
{hash}
</a>
Expand Down
2 changes: 1 addition & 1 deletion src/pages/manage/components/version-table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ const TestQrCode = ({ name, hash }: { name?: string; hash: string }) => {
target="_blank"
className="ml-1 text-xs"
href={TEST_QR_CODE_DOC}
rel="noreferrer"
rel="noopener noreferrer"
>
如何使用？
</a>
Expand Down
2 changes: 1 addition & 1 deletion src/pages/register.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export const Register = () => {
<a
target="_blank"
href="https://pushy.reactnative.cn/agreement/"
rel="noreferrer"
rel="noopener noreferrer"
>
用户协议
</a>
Expand Down
2 changes: 2 additions & 0 deletions src/pages/user.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,7 @@ function UserPanel() {
<Button
href={PRICING_LINK}
target="_blank"
rel="noopener noreferrer"
className="w-full md:w-auto"
>
查看价格表
Expand All @@ -261,6 +262,7 @@ function UserPanel() {
className="w-full md:w-auto"
href="https://pushy.reactnative.cn/docs/faq.html#%E5%8F%AF%E4%BB%A5%E4%BD%BF%E7%94%A8%E9%93%B6%E8%A1%8C%E8%BD%AC%E8%B4%A6%E4%BB%98%E6%AC%BE%E5%90%97"
target="_blank"
rel="noopener noreferrer"
>
使用网银转账
</Button>
Expand Down