Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (7)
📒 Files selected for processing (47)
📝 WalkthroughWalkthroughThe PR introduces a unified C++ patch and state management core library with native bindings for Android (JNI), iOS (Objective-C++), and HarmonyOS (N-API), replacing distributed Java/Objective-C implementation logic with centralized native implementations. Dependency versions are updated accordingly. Changes
Sequence Diagram(s)sequenceDiagram
participant JS as JavaScript/TypeScript
participant JNI as JNI/N-API Bridge
participant Core as C++ Patch Core
participant FS as File System
JS->>JNI: syncStateWithBinaryVersion(pkg, build)
JNI->>Core: pushy::state::SyncBinaryVersion(state, pkg, build)
Core->>Core: Validate version change
Core-->>JNI: Return updated State + changed flag
JNI-->>JS: Return StateCoreResult
JS->>JNI: buildArchivePatchPlan(type, entries, copies, deletes)
JNI->>Core: pushy::archive_patch::BuildArchivePatchPlan(manifest)
Core->>Core: Validate entries & build plan
Core-->>JNI: Return ArchivePatchPlan
JNI-->>JS: Return plan config (merge_source, enable_merge)
JS->>JNI: applyPatchFromFileSource(options)
JNI->>Core: pushy::patch::ApplyPatchFromFileSource(options, bundlePatcher)
Core->>FS: Validate & read origin bundle
Core->>FS: Apply patch via hdiff
Core->>FS: Write destination bundle
Core->>FS: Copy files per manifest
Core->>FS: Merge directories if enabled
Core-->>JNI: Return Status
JNI-->>JS: Void or Exception
JS->>JNI: runStateCore(operation, state, args)
JNI->>Core: pushy::state::SwitchVersion/MarkSuccess/Rollback/etc.
Core->>Core: Compute new state
Core-->>JNI: Return updated State
JNI-->>JS: Return StateCoreResult with operation outcomes
Estimated Code Review Effort🎯 4 (Complex) | ⏱️ ~50 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Documentation
Chores