Skip to content

fix(harmony): widen rnoh dependency range to support both 0.72 and 0.77+#596

Merged
sunnylqm merged 1 commit into
masterfrom
fix/harmony-dependency-range
Jul 1, 2026
Merged

fix(harmony): widen rnoh dependency range to support both 0.72 and 0.77+#596
sunnylqm merged 1 commit into
masterfrom
fix/harmony-dependency-range

Conversation

@sunnylqm

@sunnylqm sunnylqm commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

This PR updates oh-package.json5 dependency for @rnoh/react-native-openharmony from ^0.72.96 to >=0.72.96 to allow users of React Native OpenHarmony 0.77+ to install the library without peer dependency conflicts.

Summary by CodeRabbit

  • Chores
    • Broadened the supported version range for an app package, allowing compatibility with newer releases without requiring a specific pinned version.

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The dependency version constraint for @rnoh/react-native-openharmony in harmony/pushy/oh-package.json5 was changed from a caret range (^0.72.96) to a lower-bounded range (>=0.72.96), allowing any version greater than or equal to 0.72.96.

Changes

Dependency Constraint Update

Layer / File(s) Summary
Update dependency version range
harmony/pushy/oh-package.json5
Changed the @rnoh/react-native-openharmony version constraint from ^0.72.96 to >=0.72.96.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A tiny hop, a version freed,
No more caret to impede,
">=0.72.96" now set free,
Room to grow, just wait and see! 🐇
Thump-thump, ship it happily!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the dependency range update to support both 0.72 and 0.77+ OpenHarmony versions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/harmony-dependency-range

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sunnylqm sunnylqm merged commit 693c915 into master Jul 1, 2026
3 of 4 checks passed

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
harmony/pushy/oh-package.json5 (1)

12-12: 🩺 Stability & Availability | 🔵 Trivial | ⚖️ Poor tradeoff

Unbounded upper bound risks pulling in future breaking versions.

The >=0.72.96 constraint removes all upper bounds, allowing any future major or minor version (e.g., 1.0.1, 2.3.4) that may introduce breaking changes. For a published library, this can cause downstream resolution failures or runtime incompatibilities when new versions are released.

Consider constraining to tested compatible versions, e.g., >=0.72.96 <0.80.0 or ^0.72.96 || ^0.77.1, depending on your compatibility matrix. If you intentionally want broad compatibility, verify that @rnoh/react-native-openharmony follows semver and that breaking changes are reserved for major versions.

-    '`@rnoh/react-native-openharmony`': '>=0.72.96',
+    '`@rnoh/react-native-openharmony`': '>=0.72.96 <1.0.0',

Or, if 0.77 is the only additional tested version:

-    '`@rnoh/react-native-openharmony`': '>=0.72.96',
+    '`@rnoh/react-native-openharmony`': '^0.72.96 || ^0.77.1',
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@harmony/pushy/oh-package.json5` at line 12, The dependency range for
`@rnoh/react-native-openharmony` is unbounded and can pull in future breaking
releases. Update the version constraint in oh-package.json5 to a tested
upper-bounded range (for example, a compatible window like >=0.72.96 <0.80.0 or
an explicit union of tested ranges) so published consumers don’t resolve to
incompatible versions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@harmony/pushy/oh-package.json5`:
- Line 12: The dependency range for `@rnoh/react-native-openharmony` is unbounded
and can pull in future breaking releases. Update the version constraint in
oh-package.json5 to a tested upper-bounded range (for example, a compatible
window like >=0.72.96 <0.80.0 or an explicit union of tested ranges) so
published consumers don’t resolve to incompatible versions.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7ac59cb0-decf-477b-9554-4b96006fc2ec

📥 Commits

Reviewing files that changed from the base of the PR and between 4e89061 and 4a203e2.

📒 Files selected for processing (1)
  • harmony/pushy/oh-package.json5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant