Do not instrument CGLIB proxies#1983
Conversation
Since they are generated, they barely have any useful info, and the debug info is usually missing anyways. Also see spring-projects/spring-hateoas#1144
|
/cc @odrotbohm |
|
|
||
| Mono<Void> doSomething() { | ||
| Mono<Void> myMono = new MyMono(); | ||
| if (myMono == null) { |
There was a problem hiding this comment.
is that on purpose? shouldn't it be if (myMono != null) to be consistent?
There was a problem hiding this comment.
it is (see the comment)
There was a problem hiding this comment.
the comment doesn't help me understand why there's a NPE triggered here
There was a problem hiding this comment.
This is a dead code that will never get executed
But, since the operators are immutable, I removed the condition and it does not affect the test
There was a problem hiding this comment.
yeah I know it won't get executed, but since the npe is blatant it becomes a distraction and kind of forces the reader to wonder if the NPE is relevant in the test or not.
But, since the operators are immutable, I removed the condition and it does not affect the test
👍
Codecov Report
@@ Coverage Diff @@
## master #1983 +/- ##
============================================
+ Coverage 81.73% 82.09% +0.36%
- Complexity 4012 4330 +318
============================================
Files 375 375
Lines 30915 31671 +756
Branches 5808 5930 +122
============================================
+ Hits 25267 26001 +734
- Misses 4052 4064 +12
- Partials 1596 1606 +10
Continue to review full report at Codecov.
|
Since they are generated, they barely have any useful info,
and the debug info is usually missing anyways.
Also see spring-projects/spring-hateoas#1144