Consolidate release script#6
Open
cbialorucki wants to merge 6 commits intoreactos:masterfrom
Open
Conversation
learn-more
reviewed
Mar 26, 2025
learn-more
reviewed
Mar 26, 2025
learn-more
reviewed
Mar 26, 2025
da8b084 to
2c6e441
Compare
…hat no longer work with new working directory, update release script for all-in-one bootcd
learn-more
approved these changes
May 8, 2026
Member
learn-more
left a comment
There was a problem hiding this comment.
overall lgtm, some minor points.
| echo | ||
|
|
||
| # Ensure version is not null. | ||
| if [ "$version" = "" ]; then |
Member
There was a problem hiding this comment.
Do you want to do some validation on the format of the name?
| git fetch origin | ||
| fi | ||
| # Reset to the head of the branch | ||
| git reset --hard HEAD |
Member
There was a problem hiding this comment.
This means that you can never build an older release?
| # We're done! | ||
| echo | ||
| echo "*******************************************************************************" | ||
| echo "Successfully created the following packages:" |
Member
There was a problem hiding this comment.
You might want to include errors like no internet / no optional modules here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
set -euo pipefailinstead of|| exit 1on most lines/reactosdirectory instead of/workgit checkout {branch}and runningreleaseto build all deliverables