Skip to content

Consolidate release script#6

Open
cbialorucki wants to merge 6 commits intoreactos:masterfrom
cbialorucki:new_rls_script
Open

Consolidate release script#6
cbialorucki wants to merge 6 commits intoreactos:masterfrom
cbialorucki:new_rls_script

Conversation

@cbialorucki
Copy link
Copy Markdown

@cbialorucki cbialorucki commented Mar 25, 2025

Proposed changes

  • Move Dockerfile to project root
  • Move scripts to a new "Scripts" folder
  • Use set -euo pipefail instead of || exit 1 on most lines
  • Get the release name from git.
  • Use "rls" instead of "release" in the file name of deliverables (TODO: Do we still want this?)
  • Test for internet connection, if it fails disable parts of the script that require an internet connection.
  • Work out of a git clone in /reactos directory instead of /work
  • Put deliverables in a separate folder (good if we want more deliverables in the future for different architectures)
  • Consolidate script a ton, only needing to git checkout {branch} and running release to build all deliverables
  • Update README.md
  • Have the Docker image pull scripts from the local repository rather than downloading from git (so you can work on the image locally easier)
  • Probably more I forgot

@cbialorucki cbialorucki requested a review from learn-more March 26, 2025 08:21
Comment thread Scripts/release Outdated
Comment thread Scripts/release Outdated
Comment thread Scripts/release Outdated
…hat no longer work with new working directory, update release script for all-in-one bootcd
Copy link
Copy Markdown
Member

@learn-more learn-more left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm, some minor points.

Comment thread Scripts/release
echo

# Ensure version is not null.
if [ "$version" = "" ]; then
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to do some validation on the format of the name?

Comment thread Scripts/release
git fetch origin
fi
# Reset to the head of the branch
git reset --hard HEAD
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means that you can never build an older release?

Comment thread Scripts/release
# We're done!
echo
echo "*******************************************************************************"
echo "Successfully created the following packages:"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to include errors like no internet / no optional modules here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants