[AUDIOSRV][BOOTDATA][INCLUDE][MMSYS] Rename RosAudioSrv to AudioSrv#1826
[AUDIOSRV][BOOTDATA][INCLUDE][MMSYS] Rename RosAudioSrv to AudioSrv#1826HBelusca merged 2 commits intoreactos:masterfrom
Conversation
BelleNottelling
left a comment
There was a problem hiding this comment.
LGTM, but this will make testing on windows harder, and makes comments such as this no longer valid :P
Hmm, so I need to remove that comment?... |
by porting back: 0.4.15-dev-5710-g 9672dc5 CORE-16912 [AUDIOSRV] Overhaul logging interfaces (#5067) 0.4.15-dev-445-g 353b544 CORE-16814 [AUDIOSRV] Disable Logging to file (#2599) 0.4.13-dev-894-g 5f75759 CORE-16307 [AUDIOSRV][BOOTDATA][INCLUDE][MMSYS] Rename RosAudioSrv to AudioSrv (#1826) 0.4.13-dev-715-g 353e05a [AUDIOSRV] Fix the coding style. No code changes!
by porting back: 0.4.15-dev-5710-g 9672dc5 CORE-16912 [AUDIOSRV] Overhaul logging interfaces (#5067) 0.4.15-dev-445-g 353b544 CORE-16814 [AUDIOSRV] Disable Logging to file (#2599) 0.4.13-dev-894-g 5f75759 CORE-16307 [AUDIOSRV][BOOTDATA][INCLUDE][MMSYS] Rename RosAudioSrv to AudioSrv (#1826) 0.4.13-dev-715-g 353e05a [AUDIOSRV] Fix the coding style. No code changes!
by porting back: 0.4.15-dev-5710-g 9672dc5 CORE-16912 [AUDIOSRV] Overhaul logging interfaces (#5067) 0.4.15-dev-445-g 353b544 CORE-16814 [AUDIOSRV] Disable Logging to file (#2599) 0.4.13-dev-894-g 5f75759 CORE-16307 [AUDIOSRV][BOOTDATA][INCLUDE][MMSYS] Rename RosAudioSrv to AudioSrv (#1826) 0.4.13-dev-715-g 353e05a [AUDIOSRV] Fix the coding style. No code changes!
by porting back: 0.4.15-dev-5710-g 9672dc5 CORE-16912 [AUDIOSRV] Overhaul logging interfaces (#5067) 0.4.15-dev-445-g 353b544 CORE-16814 [AUDIOSRV] Disable Logging to file (#2599) 0.4.13-dev-894-g 5f75759 CORE-16307 [AUDIOSRV][BOOTDATA][INCLUDE][MMSYS] Rename RosAudioSrv to AudioSrv (#1826) 0.4.13-dev-715-g 353e05a [AUDIOSRV] Fix the coding style. No code changes!
by porting back: 0.4.15-dev-5710-g 9672dc5 CORE-16912 [AUDIOSRV] Overhaul logging interfaces (#5067) 0.4.15-dev-445-g 353b544 CORE-16814 [AUDIOSRV] Disable Logging to file (#2599) 0.4.13-dev-894-g 5f75759 CORE-16307 [AUDIOSRV][BOOTDATA][INCLUDE][MMSYS] Rename RosAudioSrv to AudioSrv (#1826) 0.4.13-dev-715-g 353e05a [AUDIOSRV] Fix the coding style. No code changes!
by porting back: 0.4.15-dev-5710-g 9672dc5 CORE-16912 [AUDIOSRV] Overhaul logging interfaces (#5067) 0.4.15-dev-445-g 353b544 CORE-16814 [AUDIOSRV] Disable Logging to file (#2599) 0.4.13-dev-894-g 5f75759 CORE-16307 [AUDIOSRV][BOOTDATA][INCLUDE][MMSYS] Rename RosAudioSrv to AudioSrv (#1826) 0.4.13-dev-715-g 353e05a [AUDIOSRV] Fix the coding style. No code changes!
Purpose
Rename RosAudioSrv to AudioSrv in audio service itself and in all system components which are related to this, same as it done in Win2k3.
It allows MS DxDiag to detect the system audio service correctly, so it becomes possible to run DirectSound test properly with MS dsound.dll, although it works with some minor errors and only in older VirtualBox versions, ~ up to 5.1.38 (and in other emulators as well).
JIRA issue: CORE-16307
Proposed changes
Rename RosAudioSrv to AudioSrv in the following source files:
base/services/audiosrv/audiosrv.txt(just description of audio service, it doesn't make any changes in the system);boot/bootdata/hivesys.inf(registry values of the audio service);dll/cpl/mmsys/mmsys.c(audio properties cpl part, which calls it also, when changing audio settings);sdk/include/reactos/libs/audiosrv/audiosrv.h(service name itself, as it named in the system and visible to other system components and to user).Result
Before:


After:

