Skip to content

[SHELL32] Support CSIDL_FLAG_NO_ALIAS#4381

Merged
katahiromz merged 1 commit intoreactos:masterfrom
katahiromz:pidl-no-alias
Mar 6, 2022
Merged

[SHELL32] Support CSIDL_FLAG_NO_ALIAS#4381
katahiromz merged 1 commit intoreactos:masterfrom
katahiromz:pidl-no-alias

Conversation

@katahiromz
Copy link
Copy Markdown
Contributor

@katahiromz katahiromz commented Mar 6, 2022

Purpose

Adding the CSIDL_FLAG_NO_ALIAS flag to SHGetSpecialFolderLocation should return the physical PIDL.
JIRA issue: CORE-18079

TODO

  • Do tests.

Comparison

BEFORE:
PidlTest-0 4 15-dev-3878-gd9f156e-FAILED

AFTER:
after

@katahiromz katahiromz added the enhancement For PRs with an enhancement/new feature. label Mar 6, 2022
@katahiromz
Copy link
Copy Markdown
Contributor Author

katahiromz commented Mar 6, 2022

Reason: PR #4381 0078d14
Branch: refs/pull/4381/head
https://build.reactos.org/
https://reactos.org/testman/

BEFORE: 08bd879 https://build.reactos.org/#/builders/9/builds/31421
AFTER: 0078d14 https://build.reactos.org/#/builders/9/builds/31423

Test KVM BEFORE: 08bd879 id=81305
Test KVM AFTER: 0078d14 id=???
https://reactos.org/testman/compare.php?ids=81305,???
Looks like failing at httpreq.

Test VBox BEFORE: 08bd879 id=81306
Test VBox AFTER: 0078d14 id=81308
https://reactos.org/testman/compare.php?ids=81306,81308
LGTM.

@katahiromz katahiromz added the bugfix For bugfix PRs. label Mar 6, 2022
@katahiromz katahiromz merged commit 6cb1e57 into reactos:master Mar 6, 2022
@katahiromz katahiromz deleted the pidl-no-alias branch March 6, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix For bugfix PRs. enhancement For PRs with an enhancement/new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant