[NTOS:KE/x64] Implement initial IPI code#6130
Merged
tkreuzer merged 1 commit intoreactos:masterfrom Dec 18, 2023
Merged
Conversation
tkreuzer
added
kernel&hal
tkreuzer
requested review from
DarkFire01,
Extravert-ir,
GeoB99,
ThFabba,
binarymaster and
zefklop
DarkFire01
approved these changes
Dec 7, 2023
Contributor
DarkFire01
left a comment
DarkFire01
left a comment
There was a problem hiding this comment.
Cool :) I'll keep the IPI code for i386 arch specific for now too like we discussed too!
HBelusca
approved these changes
Dec 8, 2023
Contributor
HBelusca
left a comment
HBelusca
left a comment
There was a problem hiding this comment.
Minor suggestions, otherwise lgtm.
| extern KSPIN_LOCK KiReverseStallIpiLock; | ||
|
|
||
| /* PRIVATE FUNCTIONS *********************************************************/ | ||
| #ifndef _M_AMD64 |
Contributor
There was a problem hiding this comment.
Suggested change
| #ifndef _M_AMD64 | |
| #ifndef _M_AMD64 |
ntoskrnl/ke/ipi.c
Outdated
| return Status; | ||
| } | ||
|
|
||
| #endif |
Contributor
There was a problem hiding this comment.
Suggested change
| #endif | |
| #endif // !_M_AMD64 |
tkreuzer
force-pushed
the
pr/ntos-x64-ipi
branch
from
90b4553 to
96e710a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR implements the basic x64 kernel IPI code. For now it only supports APC, DPC and freeze IPIs, which will be made use of soon. DPC for SMP scheduling and freeze for SMP debugging. It doesn't yet support generic function IPIs, which are a bit more complex and will come later.