[SHELL32] Correctly compare pidls for SHBrowseForFolder BFFM_SETEXPANDED #7499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_ILIsEqualSimple just does a memcmp and that does not work for all items
whindsaks
added
enhancement
Member
Can be potentially linked to CORE-13950. |
learn-more
reviewed
Nov 10, 2024
learn-more
approved these changes
Nov 10, 2024
HBelusca
reviewed
Nov 10, 2024
| #define PT_FOLDERTYPEMASK 0x70 | ||
| #define PT_DESKTOP_REGITEM 0x1F // => SHDID_ROOT_REGITEM | ||
| #define PT_COMPUTER_REGITEM 0x2E // => SHDID_COMPUTER_OTHER | ||
| #define PT_COMPUTER_REGITEM 0x2E // => SHDID_COMPUTER_? |
Contributor
There was a problem hiding this comment.
Do you mean, any of the SHDID_COMPUTER_* defines?
Contributor
Author
There was a problem hiding this comment.
No, I mean more research is required about the drive letter items. Specifically drive letters which failed GetDriveType when they were created vs actual regitems (Control panel etc in this folder). This will happen when SHGDFIL_DESCRIPTIONID gets implemented.
HBelusca
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_ILIsEqualSimplejust does amemcmpand that does not work for all items. Using a corrected version ofILIsEqualmakes it much better at matching items. As a bonus, this also fixes detection of deleted folders (fromSHChangeNotifynotifications) in Explorer/DefView automatically without having to manually refresh.Notes:
BROWSEINFO::pidlRootinitializes the dialog like Windows.BIF_NOTRANSLATETARGETSon XP+.