[DLL:WIN32][CMAKE] Introduce set_wine_module and delete -D__WINESRC__ #7800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katahiromz
commented
Mar 19, 2025
HBelusca
reviewed
Mar 21, 2025
| endfunction() | ||
|
|
||
| # FIXME: Replace this call with set_wine_module | ||
| function(set_wine_module_FIXME_2 TARGET) |
Contributor
There was a problem hiding this comment.
Out of curiosity, what did you want to test with these two versions "FIXME_1" and "FIXME_2" ?
katahiromz
added a commit
that referenced
this pull request
Mar 21, 2025
Related to #7800. Reduce code dependency on Wine. JIRA issue: CORE-5743 - Wrap DLL_WINE_PREATTACH usage by #ifndef __REACTOS__ and #endif. - Undefine DLL_WINE_PREATTACH macro in sdk/include/xdk/winnt_old.h.
[USBCCGP] Ignore invalid devices Group audio function interfaces together [USBPORT] Prevent infinite loop in USBPORT_OpenPipe when endpoint is not becoming ready
Supports multiple drives in a single property sheet CORE-20025
Based on @Doug-Lyons's wordpad-ruler-fix-05.patch. JIRA issue: CORE-19870 In IntRequestFontSize function, if lfWidth < 10, then req.width = 0;. Co-authored-by: Doug Lyons <douglyons@douglyons.com>
…o the default (reactos#7794) CORE-18839
Follow-up of reactos#7795. This affects boot condition of es-CR, rm-CH, ur-PK, fa-IR, vi-VN, ka-GE, bn-IN and my-MM users. EDIT: These languages are not supported in base/setup/usetup/ muilanguages.h yet. JIRA issue: CORE-19496 Modify boot/bootdata/hivesys.inf t o change the values of HKEY_LOCAL_MACHINE\SYSTEM\ CurrentControlSet\Control\Nls\ Language and HKEY_LOCAL_MACHINE\SYSTEM\ CurrentControlSet\Control\Nls\ Locale registry keys.
…o structure (reactos#7734) FileHandle gets initialized completely in IsoSearchDirectoryBufferForFile() - Also mark some functions as static.
…me buffer (reactos#7734) The FileName buffer is NUL-terminated later on.
…os#7734) This patch reduces the number of sectors read by 709 (from 8788 to 8079)
Related to reactos#7800. Reduce code dependency on Wine. JIRA issue: CORE-5743 - Wrap DLL_WINE_PREATTACH usage by #ifndef __REACTOS__ and #endif. - Undefine DLL_WINE_PREATTACH macro in sdk/include/xdk/winnt_old.h.
github-actions
bot
added
drivers
Contributor
Author
|
My mistake of Git management. Closed. |
2 tasks
katahiromz
added a commit
that referenced
this pull request
Apr 4, 2025
Re-trial of #7800. Deleting __WINESRC__ hacks. JIRA issue: CORE-5743 - Add sdk/cmake/set_wine_module.cmake. - Load set_wine_module.cmake at top-level CMakeLists.txt. - Use set_wine_module cmake function and delete __WINESRC__ as possible. - Delete many include_directories.
katahiromz
added a commit
to katahiromz/reactos-1
that referenced
this pull request
Apr 22, 2025
Related to reactos#7800. Reduce code dependency on Wine. JIRA issue: CORE-5743 - Wrap DLL_WINE_PREATTACH usage by #ifndef __REACTOS__ and #endif. - Undefine DLL_WINE_PREATTACH macro in sdk/include/xdk/winnt_old.h.
katahiromz
added a commit
to katahiromz/reactos-1
that referenced
this pull request
Apr 22, 2025
Re-trial of reactos#7800. Deleting __WINESRC__ hacks. JIRA issue: CORE-5743 - Add sdk/cmake/set_wine_module.cmake. - Load set_wine_module.cmake at top-level CMakeLists.txt. - Use set_wine_module cmake function and delete __WINESRC__ as possible. - Delete many include_directories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
JIRA issue: CORE-5743
Proposed changes
sdk/cmake/set_wine_module.cmake.set_wine_module.cmakeat top-levelCMakeLists.txt.set_wine_modulecmake function and delete-D__WINESRC__indll/win32/**/CMakeLists.txt.include_directories.