Conversation
This test currently has a different execution order in my adapter, so let's document the expected execution order.
SimonFrings
left a comment
There was a problem hiding this comment.
Hey @kelunik, thanks for your work on this 👍
I suggested a few changes below. Can you also place this test a bit lower in this test class. We try to have the easiest/simplest tests at the top and it progresses in complexity as you go down.
Co-authored-by: Simon Frings <simon.frings1@web.de>
Co-authored-by: Simon Frings <simon.frings1@web.de>
|
@SimonFrings Done. 👍 |
|
@kelunik thanks for the update 👍 The test itself in its functionality and the overall design looks great. I talked with @clue about this and it looks like your testcase is already covered by other tests and didn't raise the overall code coverage. I would argue that it wouldn't make sense to add a test just to show a specific example of what is possible. |
|
I'm closing this for now as it hasn't received any input in a while and I believe this has been answered. If you feel this is still relevant, please come back with more details and we can always reopen this 👍 Thank you for your effort nonetheless, keep it up! 👍 |
This test currently has a different execution order in my adapter, so let's document the expected execution order.