Revert automatic cancellation of pending collection promises #61
Conversation
CHANGELOG.md
Outdated
| * 2.4.2 (xxxx-xx-xx) | ||
|
|
||
| * Revert automatic cancellation of pending collection promises once the | ||
| output promise resolves. This was introduced in 42d86b7 and was both |
|
BC breaks is certainly something we want to avoid and it probably makes sense to revert this 👍 I'm unsure if the behavior the original change did introduce is not something others could possibly depend on, thus making this a BC break again :) Does it make sense to preserve both behaviors through a toggle as originally discussed? |
|
Good point, i'd like to avoid adding some toggle parameters to the function signatures though. I'd propose adding notes both to the changelog and the readme to explain the behavior change and how to keep the automatic cancellation. What do you think? |
I understand this, but I'd like to hear some more thoughts on this. Personally, I've used a very similar cancellation behavior in https://github.com/clue/php-block-react#awaitall. While this may be handy at times, this is not something that must be implemented in this promise library. My position would be: I feel that it may make sense to keep both here, do we have any good reasons against this? The changelog looks good to me (though the release tag may still be subject to discussion) 👍 |
According to semver, reverting a BC break should go into a new minor version.
I'd rather add a
Yes, thanks for the hint. Fixed the version. 👍 |
|
I'd like to make progress on this. Any thoughts on this? Ping @cboden @WyriHaximus @clue |
This reverts automatic cancellation of pending collection promises once the output promise resolves. This was introduced in 42d86b7 and was both unintended and backward incompatible.
Note: This is for 2.x