fix(docker): enhance security and address themeColor warning#115
Conversation
Resolves reactplay#109. Updates Dockerfile Node version and adds apk upgrade per admin feedback. Moves themeColor metadata to viewport export.
✅ Deploy Preview for reactkolkata ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @priyankarpal, I've submitted this PR to address Issue #109. It includes the Docker security improvements we discussed (updated Node.js version in I've tested the Docker build and the dev server locally, and everything seems to be working correctly regarding these specific fixes. Regarding other console messages: Please let me know if any further changes are needed for this PR! |
Resolves #109. Updates Dockerfile Node version and adds apk upgrade per admin feedback. Moves themeColor metadata to viewport export.
Summary
This PR addresses Issue #109 by implementing Docker security improvements based on admin feedback and resolving the console warning related to
themeColormetadata configuration.Changes
Dockerfile:node:20.18.0-alpine3.20) for improved security.RUN apk update && apk upgrade --no-cacheat the beginning of both the build and production stages to ensure OS packages are up-to-date.src/modules/home/meta/site.ts:themeColorproperty from thesiteConfigmetadata object.src/app/[locale]/layout.tsx:Viewporttype fromnext.viewportexport containing thethemeColorconfiguration, following current Next.js best practices.Testing
I tested these changes locally by:
pnpm run devand confirming thethemeColorwarning no longer appears in the browser console.docker-compose up --buildand verifying:Dockerfile.http://localhost:3000.Related Issue
Resolves #109
Notes
themeColorwarning.next/imagemissingsizesprops and the React hydration error (#418) are outside the scope of this PR and should be addressed in dedicated issues.