Skip to content

fix: Broken cover images #1699#1700

Merged
priyankarpal merged 1 commit intoreactplay:mainfrom
iamankeshsharma:main
Mar 23, 2026
Merged

fix: Broken cover images #1699#1700
priyankarpal merged 1 commit intoreactplay:mainfrom
iamankeshsharma:main

Conversation

@iamankeshsharma
Copy link
Contributor

Before creating this PR, please confirm the following:


First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Added a PlayThumbnailFallback component that renders whenever the cover image is missing (null), improving UI consistency and preventing empty states.

Fixes #1699

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested manually by resizing viewport.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

566692837-3288a183-6c4f-42bd-ad05-7b65030f07f6

@netlify
Copy link

netlify bot commented Mar 21, 2026

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit 1efffb3
🔍 Latest deploy log https://app.netlify.com/projects/reactplayio/deploys/69be39ab2f374f00096bb370
😎 Deploy Preview https://deploy-preview-1700--reactplayio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@iamankeshsharma
Copy link
Contributor Author

Hey @priyankarpal,
Could you plz review?

@priyankarpal priyankarpal merged commit 54ea9d9 into reactplay:main Mar 23, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: Broken cover images

2 participants