Skip to content

ignore(ci): bump deps#448

Merged
whalekeykeeper merged 7 commits intomasterfrom
deps-update
Jun 11, 2021
Merged

ignore(ci): bump deps#448
whalekeykeeper merged 7 commits intomasterfrom
deps-update

Conversation

@duncdrum
Copy link
Member

@duncdrum duncdrum commented Jan 7, 2021

bump dependencies to more recent version where this is straightforward on CI

close #447

@duncdrum duncdrum added this to the 1.1.0 milestone Jan 7, 2021
@whalekeykeeper whalekeykeeper marked this pull request as ready for review January 8, 2021 15:04
@duncdrum duncdrum marked this pull request as draft January 8, 2021 15:08
@duncdrum
Copy link
Member Author

duncdrum commented Jan 11, 2021

ok i found and fixed the wrong resource descriptors, but now i m struggling with lading loading schemas from path expressions, @whalekeykeeper feel free have a go at it just create a new branch of this one.

@whalekeykeeper whalekeykeeper marked this pull request as ready for review January 17, 2021 23:50
@whalekeykeeper
Copy link
Contributor

ok i found and fixed the wrong resource descriptors, but now i m struggling with lading schemas from path expressions, @whalekeykeeper feel free have a go at it just create a new branch of this one.

First I would like to ask what do you mean by saying "land schemas from path expression". Can you explain a bit which part of CI it is in?
Secondly, sorry I happen to click on "ready to review" button. I want to undo it by following this page :https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/changing-the-stage-of-a-pull-request. But I cannot see the "convert to draft" button.

@duncdrum duncdrum marked this pull request as draft January 18, 2021 08:50
@duncdrum
Copy link
Member Author

duncdrum commented Jan 18, 2021

If you look at the log on Travis you ll see

resource-error  The data resource has an error: "'schema/Act.json' is not of type 'object'" at "schema" in metadata and at "properties/schema/type" in profile

Ie the Schema isn't loaded from the path: "schema/Act.json" expression. It is loaded when copying the contents into the datapackage.json. This is a known issue and should be fixed with the next release of frictionless

duncdrum added 3 commits June 8, 2021 01:08
upgrade Python, switch to frictionless, VM to focal
see #447
@duncdrum duncdrum marked this pull request as ready for review June 7, 2021 23:22
@duncdrum duncdrum force-pushed the deps-update branch 5 times, most recently from 0cee322 to 3e2d7d2 Compare June 8, 2021 13:59
@duncdrum duncdrum force-pushed the deps-update branch 2 times, most recently from 68d7036 to 0b29c49 Compare June 8, 2021 14:20
@duncdrum duncdrum requested a review from whalekeykeeper June 8, 2021 14:56
@duncdrum
Copy link
Member Author

ping @whalekeykeeper

Copy link
Contributor

@whalekeykeeper whalekeykeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@whalekeykeeper whalekeykeeper merged commit 3a7f963 into master Jun 11, 2021
@whalekeykeeper whalekeykeeper deleted the deps-update branch June 11, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update dependencies on CI

2 participants